Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove global toFree list from Python interop module #26493

Merged
merged 8 commits into from
Jan 14, 2025
Merged

Remove global toFree list from Python interop module #26493

merged 8 commits into from
Jan 14, 2025

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Jan 8, 2025 •
edited
Loading

Removes the global toFree list from the Python interop module, which was a workaround for mishandling Python decrefs.

Resolves future work from #26353

  • Tested start_test test/library/packages/Python

[Reviewed by @DanilaFe]

DanilaFe
DanilaFe approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@DanilaFe DanilaFe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's difficult to fully verify the decref discipline by reading a diff as I am, but assuming all your memleaks tests pass and you can invoke that dreaded NumPy tensor fn, I think this is good to go.

@jabraham17 jabraham17 requested a review from DanilaFe January 10, 2025 18:43
@jabraham17 jabraham17 mentioned this pull request Jan 14, 2025
Merged
1 task
DanilaFe
DanilaFe approved these changes Jan 14, 2025
View reviewed changes
modules/packages/Python.chpl Outdated Show resolved Hide resolved
modules/packages/Python.chpl Outdated Show resolved Hide resolved
test/library/packages/Python/examples/bs4/python_libs.notest Outdated Show resolved Hide resolved
@jabraham17
remove toFree
ebe21ec 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
add notest
eaf5b3a 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
cleanups for decref
d384680 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
improve myModel test
e801b44 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
improve lambdas test
8e89d07 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
add back Value.value
3209bd2 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
remove debug code
966c622 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17
fix formatting
8b9c31c 
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17 jabraham17 merged commit 8dd68e5 into chapel-lang:main Jan 14, 2025
8 checks passed
@jabraham17 jabraham17 deleted the remove-toFree branch January 14, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanilaFe DanilaFe DanilaFe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jabraham17 @DanilaFe